Skip to content

fix: Update ipcheck #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Update ipcheck #454

wants to merge 1 commit into from

Conversation

umgefahren
Copy link

@umgefahren umgefahren commented Oct 2, 2024 •
edited
Loading

  • Update .NET version to make it compile on my computer
  • Correct use of .NETs IsIPv6UniqueLocal. It's actually unsupported on IPv4, previously it gave false positives.
  • Include Rust's support for is_unicast_link_local

Differentes remain:
Go and Rust have different opinions on is_global.
One loopback address remains debated: Rust should also check if an IPv6 address is actually an IPv4 mapped to IPv6 and is loopback.

Rust differentiates unicast_link_local and IPv4 to IPv6 mapped addresses that are link local (in IPv4 definition).

@umgefahren umgefahren mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@umgefahren